Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for a number of reported bugs #901

Merged
merged 5 commits into from
Jul 10, 2021
Merged

Fixes for a number of reported bugs #901

merged 5 commits into from
Jul 10, 2021

Commits on Jul 10, 2021

  1. Fix broken filename argument handling (issue olivierkes#898) 

    In addition to fixing the bug, related code that allowed this one to
slip under the radar has been cleaned up. Validation of the FILENAME
argument is now performed during parsing.
    @worstje
    worstje committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    0a0ffb6 View commit details
    Browse the repository at this point in the history

  2. Share OpenGL contexts to make Qt WebEngine happy 

    This takes care of the following warning in our log file:

Qt WebEngine seems to be initialized from a plugin. Please set
Qt::AA_ShareOpenGLContexts using QCoreApplication::setAttribute before
constructing QGuiApplication
    @worstje
    worstje committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    0ea4c0d View commit details
    Browse the repository at this point in the history

  3. Bugfix for filtering on POV characters 

    If a project only had one character, and it was marked as a POV
character, then that could lead to the accessing of a non-existent
second character. (Yes. That code was very broken.)

Fixes issues 843, 875, 896.
    @worstje
    worstje committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    87f1fc0 View commit details
    Browse the repository at this point in the history

  4. Partial fix for erroneous nbsp->space conversion 

    QDocument::toPlainText() has the stupid decision to convert nbsp to
spaces in it, which our users obviously hate. Unfortunately, this is
out of our control to fix completely. It is a very deep rabbit hole. :(

Typing non-breaking spaces in the editor now works. Reopening these
files at a later point has these characters remain intact.

What does NOT work is copy-pasting non-breaking spaces. These will end
up looking like normal spaces when you paste them somewhere else, be it
in Manuskript or some other document. In other words: it is impossible
for users to verify whether something is a non-breaking space or an
ordinary one.

I realize that it makes this partial fix meaningless for many. Sorry. :/

Partially fixes issue 738.
    @worstje
    worstje committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    32caf6a View commit details
    Browse the repository at this point in the history

  5. Implemented fix for failed cursor iteration (olivierkes#729) 

    A long time ago, I identified this failure but wasn't sure why it was
failing. I still don't know why, but the emergency fix at least prevents
other people from running into it. As a bonus, since we have a proper
logging facility now, we can actually log it as I desired to do back
then!

This commit tentatively fixes issue 729.
    @worstje
    worstje committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    d6e472b View commit details
    Browse the repository at this point in the history