Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some memes #21

Closed
wants to merge 1 commit into from
Closed

Add some memes #21

wants to merge 1 commit into from

Conversation

JesseTG
Copy link

@JesseTG JesseTG commented Feb 8, 2016

However, I can't actually tell Clojure from a hole in the ground. So, no guarantee that the syntax is correct.

Man, you should really section this part off to a data file or something.

@oliyh oliyh closed this in 2c46be8 Feb 8, 2016
@oliyh
Copy link
Owner

oliyh commented Feb 8, 2016

Thanks @JesseTG! The matching parsing pattern is quite tightly coupled to the function generating the strings that get used to create the meme, which prevents it being just data at the moment, but it is definitely something I would like to improve!

@JesseTG
Copy link
Author

JesseTG commented Feb 8, 2016

Sounds good to me. I like how quickly it was deployed. If I want a meme implemented, do you just want me to file an issue in the future?

@oliyh
Copy link
Owner

oliyh commented Feb 8, 2016

Up to you - there are some other changes which also need to be made which you may or may not be comfortable doing (see the commit which closed this issue). I'm happy to implement if you provide the general pattern and the template on memecaptain.

Deployment will generally be instant once the change is made and the build passes!

@JesseTG
Copy link
Author

JesseTG commented Feb 8, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants