Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Uncaught TypeError: The "path" ... #235

Closed
1 task done
dajotim937 opened this issue Jun 10, 2024 · 3 comments
Closed
1 task done

[Bug]: Uncaught TypeError: The "path" ... #235

dajotim937 opened this issue Jun 10, 2024 · 3 comments
Assignees
Milestone

Comments

@dajotim937
Copy link

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

OpenComic Version

1.2.0

Operating System

Win10, 22H2, build 19045

Steps to reproduce

To be honest, I caught that error almost week ago so I don't remember exactly what was cause of it.
What I remember: I read cbz files in folder (added to library via master folder). Then I renamed them (from " - c0**" to "c0**") and after that when I opened folder in app, I got that error

Expected Behavior

Not having error.

Actual Behavior

Uncaught TypeError: The "path" argument must be of type string. Received undefined
    at validateString (node:internal/validators:162:11)
    at Object.normalize (node:path:309:5)
    at Readable.<anonymous> (C:\Users\***\AppData\Local\Programs\OpenComic\resources\app.asar\scripts\file-manager.js:1879:34)
    at Readable.emit (node:events:518:28)
    at addChunk (node:internal/streams/readable:559:12)
    at readableAddChunkPushObjectMode (node:internal/streams/readable:536:3)
    at Readable.push (node:internal/streams/readable:391:5)
    at Object.bodyData (C:\Users\***\AppData\Local\Programs\OpenComic\resources\app.asar\node_modules\node-7z\src\maybe.js:77:12)
    at C:\Users\***\AppData\Local\Programs\OpenComic\resources\app.asar\node_modules\node-7z\src\events.js:83:11
    at Socket.<anonymous> (C:\Users\***\AppData\Local\Programs\OpenComic\resources\app.asar\node_modules\node-7z\src\lifecycle.js:64:51)
Screenshots

2024-06-04_03-14-26
2024-06-04_03-14-22
2024-06-04_03-16-33

Error message

No response

Additional Information

No response

Sample file

No response

@dajotim937 dajotim937 added the bug label Jun 10, 2024
@dajotim937
Copy link
Author

So yeah, got same error again.

  1. Folder with bunch of cbz files with name "## - Ep.#"
  2. Read 10 of them.
  3. Mass rename to "Ep.#"
  4. Open folder in OpenComic again and got the error.
  5. Cleared temp and cash, instead of many errors got only one.

@ollm ollm self-assigned this Jun 20, 2024
@ollm
Copy link
Owner

ollm commented Jun 20, 2024

At the moment I have not been able to reproduce the error, from what i see, it seems that the error occurs when reading the cbz file using 7zip.

Can you try the following build? Has a fix related to 7zip when reading certain files 27c863b

Build: https://mega.nz/file/zbx3maAK#UP67deOXFB39shZGfinJgTYjhuH2JRri_v-sVMoBUug

@ollm ollm added this to the v1.3.0 milestone Aug 11, 2024
@ollm
Copy link
Owner

ollm commented Oct 4, 2024

Closed as fixed and available in v1.3.0

@ollm ollm closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants