Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$modal has been renamed to $uibModal in ui-bootstrap 0.14.0 #200

Closed
mattlewis92 opened this issue Oct 9, 2015 · 10 comments
Closed

$modal has been renamed to $uibModal in ui-bootstrap 0.14.0 #200

mattlewis92 opened this issue Oct 9, 2015 · 10 comments

Comments

@mattlewis92
Copy link

See: angular-ui/bootstrap@8c7b9e4

Thanks! 😄

@olov
Copy link
Owner

olov commented Oct 9, 2015

Thanks for the heads-up! I guess we'll need to support both $modal and $uibModal then. Will do for next release.

@olov olov added the S label Oct 9, 2015
@mattlewis92
Copy link
Author

Fantastic, thank you!

@char0n
Copy link

char0n commented Oct 16, 2015

Any workaround now ?

This is what i can think of:

1.) explicitly annotate all javascript code with @ngInject
2.) some sort of override on config level

Any suggestions ?

@olov
Copy link
Owner

olov commented Oct 19, 2015

The workaround is to annotate your angular-ui modals with "ngInject" or /*@ngInject*/.

@ashgibson
Copy link

Any update on when this will be updated?

@olov olov added the next label Dec 1, 2015
@kld87
Copy link

kld87 commented Dec 5, 2015

+1

I notice there's a pull open to fix this issue

@olov olov closed this as completed in bf1a7c0 Dec 19, 2015
@olov
Copy link
Owner

olov commented Dec 19, 2015

released in 1.1.0

@eavestn
Copy link

eavestn commented Feb 12, 2016

olov Should I now be seeing $modal instead of $uibModal?

@olov
Copy link
Owner

olov commented Feb 12, 2016

@eavestn ng-annotate understands $uibModal.open and $modal.open, whichever you use

@jjayaraman
Copy link

Thanks it helped... I was struggling with old name $modal in a old code..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants