Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename option "sighup-file" to "writefiles_interval" #15

Closed
SvenRoederer opened this issue Jan 12, 2017 · 5 comments
Closed

rename option "sighup-file" to "writefiles_interval" #15

SvenRoederer opened this issue Jan 12, 2017 · 5 comments

Comments

@SvenRoederer
Copy link
Contributor

I just wonder if it would be more consistent to name this new parameter "writefiles_interval", as it affects the interval when following files are written:

  • resolve-file
  • hosts-file
  • services-file
  • latlon-file

referencing to commit (

olsr_expire_write_file_timer(void *context __attribute__ ((unused)))
)

@fhuberts
Copy link
Contributor

AFAIK there is no consensus between you guys (in the other issue), so please first have that.
Otherwise there'll be commit after commit on this.

@SvenRoederer
Copy link
Contributor Author

@booo so I'll rename it spoken yesterday, then we can integrate the new option into openwrt-routing.
Maybe the option should named "filewrite_interval", which I prefer (now).

@bittorf
Copy link
Contributor

bittorf commented Jan 12, 2017

@SvenRoederer - so if this is only done/an issue on theOpenWrt/LEDE-side, just close this ticket

@booo
Copy link
Contributor

booo commented Jan 12, 2017

@SvenRoederer I don't care. I do think the current name is not too bad because it references to the sighup-pid-file which creates kind of the right context. If the name is "filewrite_interval" you only get the context if you read the code.

@fhuberts
Copy link
Contributor

fixed by #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants