-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename option "sighup-file" to "writefiles_interval" #15
Comments
AFAIK there is no consensus between you guys (in the other issue), so please first have that. |
@booo so I'll rename it spoken yesterday, then we can integrate the new option into openwrt-routing. |
@SvenRoederer - so if this is only done/an issue on theOpenWrt/LEDE-side, just close this ticket |
@SvenRoederer I don't care. I do think the current name is not too bad because it references to the sighup-pid-file which creates kind of the right context. If the name is "filewrite_interval" you only get the context if you read the code. |
fixed by #16 |
I just wonder if it would be more consistent to name this new parameter "writefiles_interval", as it affects the interval when following files are written:
referencing to commit (
olsrd/lib/nameservice/src/nameservice.c
Line 544 in 9a0d5db
The text was updated successfully, but these errors were encountered: