Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with three.js v81 (String.prototype.isColor) #872

Closed
nidu opened this issue Sep 29, 2016 · 1 comment
Closed

Conflict with three.js v81 (String.prototype.isColor) #872

nidu opened this issue Sep 29, 2016 · 1 comment

Comments

@nidu
Copy link

nidu commented Sep 29, 2016

Hello, i'm using three.js and metro-ui (v 3.0.13) in a single project. After update to new three.js (v81) i've noticed an interesting bug, particularly here at line 7300 where a method isColor on some object is called. This object can be of different type including string. Metro defines String.prototype.isColor so e.g. 'abc'.isColor would return true. This causes method to fail (i guess three.js doesn't expect isColor on a string). So i just can't use WebGLRenderer with metro-ui.

Is there anything we can do about it? How do you think - should this problem be resolved in metro-ui or three.js (i personally think that in metro-ui)?

@olton
Copy link
Owner

olton commented Nov 28, 2016

Fixed in develop brach, Function moved from prototype to metroUtils object

@olton olton closed this as completed Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants