Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current practice of copying the perfetto.cc/h files seems to be in contradiotion with what meson supports #6

Open
gerddie opened this issue Jan 29, 2021 · 1 comment

Comments

@gerddie
Copy link
Contributor

gerddie commented Jan 29, 2021

When I run meson on percetto, I get an error

Message: Perfetto SDK: /home/gerddie/src/Collabora/virgl-gitlab/build-percetto/../subprojects/perfetto-sdk
|../subprojects/percetto/perfetto-sdk/meson.build:45: WARNING: Custom target input '['/home/gerddie/src/Collabora/virgl-gitlab/build-percetto/../subprojects/perfetto-sdk/perfetto.cc', '/home/gerddie/src/Collabora/virgl-gitlab/build-percetto/../subprojects/perfetto-sdk/perfetto.h']' can't be converted to File object(s).
|This will become a hard error in the future.

So in the future this method of just copying the files over will no longer work.

@olvaffe
Copy link
Owner

olvaffe commented Jan 29, 2021

We don't really need input:. This is a "codegen" target, and we know how to codegen from just the sdk path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants