Factoring out String length check. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All string generating methods were performing the same check for the type and value of the ``length`` argument. I have created a new ``is_valid_length`` method that removes the redundant code and seems to speed up tests ten-fold.
Also use it to perform a validation check in `generate_iplum`.
|
Great set of changes. I've created a pull request with some additional, fairly minor tweaks on top of your work. I've renamed The only thing I'm iffy about is the formatting used in method |
Rename `is_valid_length` to `_is_positive_int`
omaciel
added a commit
that referenced
this pull request
May 18, 2014
Factoring out String length check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All string generating methods were performing the same check for the
type and value of the
lengthargument. I have created a newis_valid_lengthmethod that removes the redundant code and seems tospeed up tests ten-fold.