Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factoring out String length check. #23

Merged
merged 4 commits into from
May 18, 2014
Merged

Factoring out String length check. #23

merged 4 commits into from
May 18, 2014

Commits on May 17, 2014

  1. Factoring out String length check. 

    All string generating methods were performing the same check for the
type and value of the ``length`` argument. I have created a new
``is_valid_length`` method that removes the redundant code and seems to
speed up tests ten-fold.
    @omaciel
    omaciel committed May 17, 2014
    Configuration menu
    Copy the full SHA
    1e8b62e View commit details
    Browse the repository at this point in the history

Commits on May 18, 2014

  1. Rename is_valid_length to is_positive_int 

    Also use it to perform a validation check in `generate_iplum`.
    @Ichimonji10
    Ichimonji10 committed May 18, 2014
    Configuration menu
    Copy the full SHA
    29b2402 View commit details
    Browse the repository at this point in the history

  2. Make method private

    @Ichimonji10
    Ichimonji10 committed May 18, 2014
    Configuration menu
    Copy the full SHA
    f3b05fd View commit details
    Browse the repository at this point in the history

  3. Merge pull request #24 from Ichimonji10/refactor-string-length 

    Rename `is_valid_length` to `_is_positive_int`
    @omaciel
    omaciel committed May 18, 2014
    Configuration menu
    Copy the full SHA
    1b2a5ff View commit details
    Browse the repository at this point in the history