Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More thoroughly test method generate_html #34

Merged
merged 1 commit into from
Sep 17, 2014
Merged

More thoroughly test method generate_html #34

merged 1 commit into from
Sep 17, 2014

Conversation

Ichimonji10
Copy link
Contributor

Create a battery of three tests for method generate_html. These tests check
that:

  • The string returned is unicode.
  • If the length argument is omitted, the contents of the returned HTML tag are
    at least one character long.
  • If the length argument is provided, the contents of the returned HTML tag are
    of the provided length.

Fixes #33.

@Ichimonji10
Copy link
Contributor Author 

[ichimonji10@beech:fauxfactory]$ python -m unittest tests.test_html
...
----------------------------------------------------------------------
Ran 3 tests in 0.001s

OK

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling deaf2f6 on Ichimonji10:test-generate-html into 86c9e00 on omaciel:master.

@Ichimonji10
More thoroughly test method generate_html
bb5270c 
Create a battery of three tests for method `generate_html`. These tests check
that:

* The string returned is unicode.
* If the `length` argument is omitted, the contents of the returned HTML tag are
  at least one character long.
* If the `length` argument is provided, the contents of the returned HTML tag
  are of the provided length.

Fixes #33.

Add Kedar Bidarkar to the authors file.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ccc0161 on Ichimonji10:test-generate-html into 86c9e00 on omaciel:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling bb5270c on Ichimonji10:test-generate-html into 86c9e00 on omaciel:master.

@omaciel
Copy link
Owner

omaciel commented Sep 17, 2014

Huh I never knew about assertGreaterEqual. ACK

omaciel added a commit that referenced this pull request Sep 17, 2014
@omaciel
Merge pull request #34 from Ichimonji10/test-generate-html
93b061d 
More thoroughly test method generate_html
@omaciel omaciel merged commit 93b061d into omaciel:master Sep 17, 2014
@Ichimonji10 Ichimonji10 deleted the test-generate-html branch September 17, 2014 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add few tests related to the new function generate_html
3 participants
@Ichimonji10 @coveralls @omaciel