-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscribe/Unsubscribe UI rework #118
Comments
Oh, and maybe use javascript or something to send the "subscribe signal" to Invidious instead of relying on redirecting the user to the main page, etc. |
Sounds good! |
But the thing is, it's very easy to load a script that replaces the current 'Subscribe' button with a non-redirecting one. Or the very least, something could be worked out so that playback continues from the point you clicked subscribe. |
That's fair enough, I think I spoke too soon. |
Added with 1a39fae. |
Thanks for this! I don't think the blue color fits for it though.
|
That's true, although you could make the same argument for YouTube's interface: I think it makes sense for a "call to action" per se to be in a contrasting color, trying out some of the other main colors (grey colors) used elsewhere don't seem as appropriate. @dimqua has made some very nice improvements to the color scheme, I'd be curious if he has any thoughts on this. |
@Discookie @omarroth What about these colors?
|
I'd personally go with #f0f0f0 for background color - the contrast is too low with a0 and I'm having trouble reading it. Other than that, I like it, and I think it fits the site a lot better! |
Only issue is with light theme, the button looks like this: If it would be better to have seperate colors for light and dark themes, I'd be open to it. @dimqua's additions added with 3c634d9. |
I think you can make the interface more clean by adding a button or just a link to subscribe to (unsubscribe from) a channel:
It should affect both
/watch
and/channel
pages.If it possible I would also add the total number of subscribers like YouTube does it:
And channel thumbnails can be helpful as well.
The text was updated successfully, but these errors were encountered: