Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads are slow and unrelyable #562

Closed
elypter opened this issue May 30, 2019 · 6 comments
Closed

Downloads are slow and unrelyable #562

elypter opened this issue May 30, 2019 · 6 comments
Labels
bug Something isn't working

Comments

@elypter
Copy link

elypter commented May 30, 2019

Quite some time ago as far as i remember downloads were quite fast and without problems. Now it feels like it is a lot slower. It seems that they are proxied through invidio.us. however i do not have the proxy setting enabled and umatrix shows the googlevidio sources. is it a bug that the downloads run over the proxy all the time or did something change with how youtube provides the video which makes it impossible to download directly? i am downloading 720p

@omarroth
Copy link
Contributor

omarroth commented May 30, 2019

Downloads are proxied to provide correct title= and for when playback is restricted in the user's region. Likely the issue is high load, see #532.

@omarroth omarroth added the bug Something isn't working label May 30, 2019
@elypter
Copy link
Author

elypter commented May 30, 2019

could you add an alternative direct download button? the occasional slow speed isn't that bad but i don't want to waste your bandwidth and slow down other users if i don't feel the need for it. maybe the renaming could be done by a userscript or an extension.

@omarroth
Copy link
Contributor

omarroth commented Jun 9, 2019

Looks like I didn't mention this above, but proxying is also used to trigger downloads. Otherwise they appear as a media element, similar to &raw=1&local=true.

I don't think a direct download button would have much utility since it would be functionally identical to Right-click -> Save as....

@omarroth
Copy link
Contributor

omarroth commented Jul 6, 2019

I've pushed out e5fa5df which should improve download speed significantly. From some brief testing most files download about 10x faster (limited by local network), although I would appreciate other reports.

In short, YouTube will throttle downloads when requesting segments >10MB (see Rudloff/alltube#217, or ytdl-org/youtube-dl@e4a6091). For downloads this commonly results in throttling down to ~300Kb or lower.

@elypter
Copy link
Author

elypter commented Jul 6, 2019

maybe add video download helper to the addon list. it downloads directly and provides a proper filename.

@omarroth
Copy link
Contributor

Closed in favor of #616.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants