Peer-to-peer code review: Ruby capstone

[BertrandConxy]

Hello team,

You have done a great job building this console app! 🎆

Highlights 🥇

✔️ Requirements are implemented well
✔️ The console app is working as expected without crashing
✔️ No linter errors
✔️ Use of Ruby best practices
✔️ All the unit tests are passing
However, there are some issues that I would like to present to you so that when you correct them, your codes will be clean and more maintainable than they are now.

Requested improvements ♻️

While looking through this project, I have noticed a lot of repetition of the similar blocks of codes while it is the best programming practice to always keep our codes DRY which means "Not Repeating similar codes multiple times". Every piece of knowledge must have a single, unambiguous, authoritative representation within a system (Andrew Hunt & David Thomas, "The Pragmatic Programmer"). Please try to look at these code snippet screenshots I took from some of your project files.

case 1

case 2

case 3

There is the repetition of the block of codes that is responsible to read data from the storage in every module which is the same for the case of writing data in the storage.

Suggested solution

I kindly recommend that you may create a Ruby module that handles all data manipulation operations (reading and writing data) and then include that module in every class that is responsible for displaying data in the storage or saving data in the storage.
For example

Then, after this module is included in a particular class, you can perform read operations

And also the write operations like this;

Thank you, happy coding! 👏