feature support more customization #18
Conversation
| @@ -11,6 +11,8 @@ | |||
| backup: false | |||
| dest: /etc/logrotate.d/haproxy | |||
| src: logrotated-haproxy.j2 | |||
| tags: | |||
| - haproxy-configure | |||
There was a problem hiding this comment.
I understand why this could be useful, but this is just one of our many openmicroscopy roles and playbooks so I'd prefer not to add tags to individual roles unless we have an overall plan.
There was a problem hiding this comment.
I understand, I'll keep it in my own code.
There was a problem hiding this comment.
Btw, do you know when/if you will have such a plan?
That tag name actually comes from @geerlingguy's original role.
There was a problem hiding this comment.
I'm afraid we don't have a timeline yet.
| @@ -36,6 +36,11 @@ defaults | |||
| errorfile 504 /etc/haproxy/errors/504.http | |||
| {% endif %} | |||
|
|
|||
| {% for proxy in haproxy_proxies %} | |||
There was a problem hiding this comment.
There's no structure to this section, i.e. there's nothing here that makes this specific to proxies, it could be used for any arbitrary configuration. How about move it to the end of the file, and call it something like haproxy_additional_config?
There was a problem hiding this comment.
Yes, I believe the role has to allow for any configurations. This makes the role usable outside the scope of the currently intended/supported uses.
I would like to add support for the stats entry later on.
I agree for the name and location. I will update this.
Hello,
This PR adds support for:
Regards