Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Remove incorrect .items() from network_additional_params #3

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

manics
Copy link
Member

@manics manics commented Mar 5, 2018

This is unnecessary, and causes an error if network_additional_params is not defined since default() only protects the first deference.

Tag: 1.1.1

This is unnecessary, and causes an error if network_additional_params is not defined
@joshmoore
Copy link
Member

This is likely coming from a cut-n-paste from me. Sorry about that. Merging & bumping based on travis status.

@joshmoore joshmoore merged commit 36e9185 into ome:master Mar 5, 2018
manics added a commit to manics/prod-playbooks that referenced this pull request Mar 5, 2018
@manics manics deleted the additional-params-fix branch March 5, 2018 16:45
@sbesson sbesson added this to the 1.1.1 milestone Mar 24, 2018
@manics
Copy link
Member Author

manics commented May 9, 2018

I think I've figured out the problem, it's iterating with (param, value) instead of just param which I didn't spot which means items() is necessary. Should've tested this ....

manics added a commit to manics/prod-playbooks that referenced this pull request Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants