MRC: read IMOD flags to determine int8 vs uint8 pixel type #3975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Changes looks good and inline with the specification linked from the reader. Nightly CI tests are passing.
I defer on the merging as we are prioritizing the dependencies upgrade work but from my side, this feels like a valuable fix to include in Bio-Formats 6.13.0.
|
Changes here look good and inline with the spec. Testing with the new sample file and with the PR included the file is able to read without issue and |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See glencoesoftware/bioformats2raw#198 (comment)
The test file has been uploaded to
curated/mrc/bioformats2raw-198. Without this PR,showinf test_uint8.mrcshould read the file, but will incorrectly identify it asint8. With this PR, the same test should show a pixel type ofuint8.I would not expect test failures, and this should be safe for a patch release.
cc @blowekamp