New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web build #19
Web build #19
Conversation
if [ -e $WORKSPACE/omeropy-virtualenv ]; then | ||
source $WORKSPACE/omeropy-virtualenv/bin/activate | ||
eval $(bash /opt/multi-config.sh ice3.5) | ||
$OMERO_DIST/bin/omero web stop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one thing that is still not clear to me how that meant to work. I thought web docker container is created every time jenkins job is run, that would result in job just passing appropriate OMERO.py artifact to the docker build. This will reduce maintenance of scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet. At the moment, the docker-compose creates a single web container which is re-used for multiple runs. We'll need to look into new jenkins plugins in order to enable the "spin up a fresh container each time" workflow. Definitely for it, but I think we should make the migration to omero-install atomically and then look at the bigger step to a many-container system.
following readme
|
- jenkins | ||
volumes: | ||
- ./web:/home/omero | ||
command: -labels web -name web -executors 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need newer swarm plugin jenkinsci/swarm-plugin#33, otherwise this is never going to work because of jenkinsci/swarm-plugin#26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using the label here to tie jobs to the correct location rather than the name. But as long as the newer plugin works with the rest of the stack, 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newer plugin is needed to disableClientsUniqueId
otherwise jenkins adds unique id to the name
is there any need for |
Probably not. I haven't quite figured out what's going on with this file. It does seem to be changed a lot. |
Closing in favor of @aleksandra-tarkowska's PR. |
This makes use of a prototype by @aleksandra-tarkowska (ome/ome-docker#29) but integrates changes from @jburel (ome/omero-install#94) for using the install scripts in other context. This work is dependent on https://hub.docker.com/r/openmicroscopy/devslave-c7 as it stands. If a different slave build is desired, clone https://github.com/openmicroscopy/devslave-c7-docker and built locally (e.g. c6, etc)
Note: a few files here need to be push-forced away.