-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omeroweb in docker container #29
Conversation
RUN yum install -y ice ice-python ice-servers && \ | ||
yum clean all | ||
|
||
# install Pillow via pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad of the comment, I'd never have guessed that's what this does!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh that is wrong
maybe this PR could help testing ome/openmicroscopy#4447 ? |
I have just pushed omero properties file |
|
||
1. Build: | ||
|
||
build -t omeroweb-deploy --build-arg ZIPURL=https://path.to.omeropy.zip . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing docker.....
Worked for me as expected. |
MAINTAINER ome-devel@lists.openmicroscopy.org.uk | ||
|
||
# To avoid error: sudo: sorry, you must have a tty to run sudo | ||
RUN sed -i -e "s/Defaults requiretty.*/ #Defaults requiretty/g" /etc/sudoers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manics are you ok if I move this to omero-ssh-systemd ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 you might as well just delete the whole line:
sed -i -re 's/Defaults\s+requiretty.*//' /etc/sudoers
@@ -0,0 +1,67 @@ | |||
FROM openmicroscopy/omero-ssh-systemd | |||
ARG ZIPURL=omego | |||
ENV ZIPURL ${ZIPURL} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need ENV
, ARG
already sets the env var
Apart from those minor comments this looks fine for a dev/test image. |
👍 |
Merging. Note: after @sbesson's and my recent experience with I won't go forward with registering this with hub until we've discussed further. |
omeroweb in docker container
This PR runs omeroweb in docker container. See readme
cc @manics @sbesson @joshmoore @mtbc
NOTE: If you don't specify
ZIPURL
it will use omego to download the latest OMERO.py