Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omeroweb in docker container #29

Merged
merged 13 commits into from
Feb 17, 2016
Merged

omeroweb in docker container #29

merged 13 commits into from
Feb 17, 2016

Conversation

atarkowska
Copy link
Member

This PR runs omeroweb in docker container. See readme

cc @manics @sbesson @joshmoore @mtbc

NOTE: If you don't specify ZIPURL it will use omego to download the latest OMERO.py

RUN yum install -y ice ice-python ice-servers && \
yum clean all

# install Pillow via pip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad of the comment, I'd never have guessed that's what this does!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh that is wrong

@atarkowska
Copy link
Member Author

maybe this PR could help testing ome/openmicroscopy#4447 ?

@atarkowska
Copy link
Member Author

I have just pushed omero properties file


1. Build:

build -t omeroweb-deploy --build-arg ZIPURL=https://path.to.omeropy.zip .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing docker.....

@pwalczysko
Copy link
Member

Worked for me as expected.

MAINTAINER ome-devel@lists.openmicroscopy.org.uk

# To avoid error: sudo: sorry, you must have a tty to run sudo
RUN sed -i -e "s/Defaults requiretty.*/ #Defaults requiretty/g" /etc/sudoers
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manics are you ok if I move this to omero-ssh-systemd ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 you might as well just delete the whole line:
sed -i -re 's/Defaults\s+requiretty.*//' /etc/sudoers

@@ -0,0 +1,67 @@
FROM openmicroscopy/omero-ssh-systemd
ARG ZIPURL=omego
ENV ZIPURL ${ZIPURL}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need ENV, ARG already sets the env var

@manics
Copy link
Member

manics commented Feb 16, 2016

Apart from those minor comments this looks fine for a dev/test image.

@manics
Copy link
Member

manics commented Feb 16, 2016

👍

@joshmoore
Copy link
Member

Merging. Note: after @sbesson's and my recent experience with octave-docker (https://www.openmicroscopy.org/private/ome-internal/instructions/docker-ops.html) it might make sense to eventually start breaking these subdirectories out into their own repositories, but that doesn't stop this from being used at the moment.

I won't go forward with registering this with hub until we've discussed further.

joshmoore added a commit that referenced this pull request Feb 17, 2016
@joshmoore joshmoore merged commit f09ca66 into ome:master Feb 17, 2016
@joshmoore joshmoore mentioned this pull request Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants