Clarify use of _ARRAY_DIMENSIONS in v0.4 and latest
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated Review URLs |
|
Looks good rendered at http://api.csswg.org/bikeshed/?url=https://raw.githubusercontent.com/ome/ngff/3fca4de96356213d9538dcc8bef688385c2bc703/latest/index.bs Readthedocs build failure above looks unrelated to this PR - will open a PR to fix that if I can find a solution... |
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2023
Clarify use of `_ARRAY_DIMENSIONS` in v0.4 and latest SHA: 6775694 Reason: push, by @will-moore Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 0.4 (and then including
latestversion),_ARRAY_DIMENSIONSis not a required attribute any more. This PR replaces the relevant "must" with a "may", and adds a clarification about the goal of this attribute (that is, it exists in view of xarray compatibility).Closes #217