Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC 1 Updates #231

Merged
merged 12 commits into from
Apr 30, 2024
Merged

RFC 1 Updates #231

merged 12 commits into from
Apr 30, 2024

Conversation

joshmoore
Copy link
Member

@joshmoore joshmoore commented Mar 13, 2024 •
edited
Loading

This PR updates RFC 1 in the following ways:

  • Lists current reviewers and commenters
  • Adds a legend for symbols like 🕑 and 📂
  • Adds a section on decision-making
  • Add a changelog to the RFC

It additionally:

  • removes the previous use of the term "Editor" throughout the specification to prevent confusion
  • [ ] clarifies how to suggest someone in particular (including oneself) as a reviewer

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2024 •
edited
Loading

Automated Review URLs

@virginiascarlett virginiascarlett mentioned this pull request Mar 20, 2024
Merged
thewtex
thewtex approved these changes Apr 30, 2024
View reviewed changes
Copy link

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating this!

@joshmoore joshmoore merged commit c9a610a into ome:main Apr 30, 2024
9 checks passed
@joshmoore joshmoore deleted the rfc-1-comment-1 branch April 30, 2024 15:07
github-actions bot added a commit that referenced this pull request Apr 30, 2024
@joshmoore @github-actions
chore(rebuild): Merge pull request #231 from joshmoore/rfc-1-comment-1
0ea959f 
RFC 1 Updates

SHA: c9a610a
Reason: push, by @joshmoore

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to d-v-b/ngff that referenced this pull request Apr 30, 2024
@joshmoore @github-actions
chore(rebuild): Merge pull request ome#231 from joshmoore/rfc-1-comme…
8c61338 
…nt-1

RFC 1 Updates

SHA: c9a610a
Reason: push, by @d-v-b

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshmoore @thewtex