add Janelia RFC-1 review #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated Review URLs |
|
Many thanks, @virginiascarlett & team. Merging. I'll update the index to make everything readable and then attach a response with the related modifications. |
github-actions bot
added a commit
that referenced
this pull request
Apr 24, 2024
…nelia_review add Janelia RFC-1 review SHA: 2c4c9bb Reason: push, by @joshmoore Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Josh Moore's request, several of us at Janelia have submitted a single review of RFC-1. We reviewed the latest version as of the start of the review period on Feb. 23 2024. In other words, we did not review the changes made in #231.
Many thanks to Josh for working hard on this and for soliciting our feedback.