2008-09 to 2009-09: Move CustomAttributes transforms to top level #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #142 and should see the unit tests in ome/bioformats#3695 turn green.
The issue appears to have been due to
CustomAttributes
being able to be located in 4 different locations:The non top level
CustomAttributes
were being transformed intoXMLAnnotations
but embedded in the original element, be it Image or Dataset, this is an invalid location for it and thus it was not being recognised when converted back to an OME-Model object. This PR aims to move allCustomAnnotations
to the top OME level before transforming them. If you have multipleCustomAttributes
at different levels then you will get multipleXMLAnnotations
inside a singleStructuredAnnotations
.Fixes #142