Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2008-09 to 2009-09: Move CustomAttributes transforms to top level #144

Closed
wants to merge 1 commit into from

Conversation

dgault
Copy link
Member

@dgault dgault commented May 21, 2021

This is a follow up to #142 and should see the unit tests in ome/bioformats#3695 turn green.

The issue appears to have been due to CustomAttributes being able to be located in 4 different locations:

  • top level under OME
  • under images
  • under images/feature
  • under dataset

The non top level CustomAttributes were being transformed into XMLAnnotations but embedded in the original element, be it Image or Dataset, this is an invalid location for it and thus it was not being recognised when converted back to an OME-Model object. This PR aims to move all CustomAnnotations to the top OME level before transforming them. If you have multiple CustomAttributes at different levels then you will get multiple XMLAnnotations inside a single StructuredAnnotations.

Fixes #142

@sbesson
Copy link
Member

sbesson commented May 21, 2021

@dgault looks like this PR has been opened from a branch on the ome/ome-model repository itself. Unfortunately, while Travis has been disabled for Pull Requests, there was a remaining webhook that created a failing build on the push event which will I cannot easily remove.

Could you either force push or recreate a PR from your fork?

@dgault dgault closed this May 24, 2021
@dgault dgault deleted the 200809-Transform-customAttr branch May 24, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OriginalMetadata from 2003-FC lost in transform process
2 participants