Implement setROIName in OMEROMetadataStoreClient #90
Conversation
There was a problem hiding this comment.
Changes look good.
Used the sample OME-TIFF generated from MitoCheck and imported it with and without this PR. In both cases, many ROIs with a single rectangle shapes were populated.
I was surprised to see the same value for Comments in both imports until I realized that OMERO.iviewer displays Shape.Text but not ROI.Name. This feels a bit at odds with the UI display which primarily refers to ROI. Maybe a RFE to include an optional column with the ROI name? /cc @will-moore @jburel
Testing the content of the DB via HQL, with this PR
(.venv3) bash-4.2$ omero hql 'select r from Roi r where r.id=276723'
Using session for user-7@localhost:4064. Idle timeout: 10 min. Current group: private-1
# | Class | Id | details | name | image
---+-------+--------+---------------------+------------------+---------------
0 | RoiI | 276723 | owner=458;group=453 | primary__test 88 | ImageI:125215
(1 row)
vs without
(.venv3) bash-4.2$ omero hql 'select r from Roi r where r.id=5400'
Using session for user-7@localhost:4064. Idle timeout: 10 min. Current group: private-1
# | Class | Id | details | image
---+-------+------+-------------------+-------------
0 | RoiI | 5400 | owner=58;group=53 | ImageI:4815
(1 row)
To see details for object, enter line number.
To move ahead one page, enter 'p'
To re-display list, enter 'r'.
To quit, enter 'q' or just enter.
Good to merge from my perspective. I am also assuming this was an oversight but leaving others to comment.
|
Do we need to do anything else on this PR or can it be merged, @sbesson? /cc @joshmoore, @jburel |
|
Looks good. iviewer RFE created ome/omero-iviewer#326 |
Importing an OME-TIFF file that defines an ROI with the
Nameattribute set currently results in the name being lost. This change should make it so that the ROI name is correctly saved during import.I'd guess this was just an oversight when names were added in ome/openmicroscopy#3362, but if there is a reason why the name can't be passed through then happy to discuss alternatives.
A minimal pyramid OME-TIFF with one named ROI is in
/uod/idr/scratch/inbox/with-roi.ome.tiff.