Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set classifier #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

set classifier #40

wants to merge 2 commits into from

Conversation

jburel
Copy link
Member

@jburel jburel commented Jan 5, 2023

The build creates 2 jars; one containing the testing code and one containing the main code.
When the jars are built from the super-build. the content of the testing jar is copying into the main jar
i.e. omero-common.jar contains the classes from omero-common-test.jar leading to a failure of the build.
This PR adds a classifier preventing this problem to occur. This is a workaround since an extra "tests" jar is created

--exclude

@jburel jburel changed the title do not publish test set classifier Jan 6, 2023
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of a classifier makes sense.

However, it raises two questions:

  • why tests while the suffix is -test
  • in general, is there a reason to keep 2 separate artifacts with the same version or should the test JAR really be another outcome of omero-common with the test[s] classifier (like Javadoc or sources)?

The second bullet point certainly wider implications in terms of all the downstream components (omero-server/omero-blitz via testImplementation and OmeroJava via test.xml) but I think both Gradle and Ivy have built-in way to specify classifiers.

@jburel
Copy link
Member Author

jburel commented Mar 6, 2023

I will need to go back to it since the packaging is done with our upstream repo.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the component release, this PR broke the daily CI build - see https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-build/1487/console

00:57:42 /home/omero/workspace/OMERO-build/src/components/tools/OmeroJava/test/integration/delete/AdditionalDeleteTest.java:14: error: package ome.testing does not exist
00:57:42 import ome.testing.ObjectFactory;

Added an exclude comment to the description which sufficed to fix the build.

I suspect the logic have been working previously because a 5.6.1-SNAPSHOT artifact without the classifier was present in the build environment and could be used by the build syste,.
If we re-include the proposed changed, we will likely need to tackle the consumption of the new artifact by downstream components as discussed in #40 (review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants