-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose upload_rm option in the documentation #975
Conversation
@ximenesuk: you can either cherry-pick the commit auto-generated by OMERO-5-1-merge-docs-autogen after ome/openmicroscopy#2999 is included into the merge build or wait until this upstream PR is merged into |
@sbesson Thanks! I'll wait on this one being merged. Hopefully that won't be a problem but I won't tempt fate. |
.. _upload_dropbox_auto: | ||
|
||
DropBox import (automatic delete) | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awfully long underline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think the heading may have been shortened!
@@ -222,7 +245,7 @@ In-place DropBox import (automatic delete) | |||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
|
|||
One option that only exists in the in-place scenario is to have | |||
files removed from DropBox automatically after a successful delete. | |||
files removed from DropBox automatically after a successful import. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still actually true if upload_rm
isn't in-place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the use of "only"? Probably not completely true, now.
Thanks @sbesson - there's no problem with that commit including other changes? |
@ximenesuk: no, it should be fine. This commit should only include changes which have been merged in the upstream repository. |
Repository: openmicroscopy/ome-documentation Already up-to-date. Generated by OMERO-5.1-latest-docs-autogen#86 (http://ci.openmicroscopy.org/job/OMERO-5.1-latest-docs-autogen/86/)
@mtbc Any further comments on the changes? |
I'd still add a couple of "much faster" words for https://github.com/openmicroscopy/ome-documentation/pull/975/files#r16982141 but apart from that the latest changes look good. |
|
@jburel Although this line is from the orignal page (ie I didn't think to address it in this PR) it could do with tweaking. However, I'm not sure that they are reading the implications but making them based on reading the docs. So maybe something more like:
/cc @joshmoore |
@ximenesuk: your suggestion really highlights the fact that people need to be careful. (excluding the "the this") |
I'd favour |
I'm happy with Helen's wording. My "the this" was a typo - honest :-) |
Better? The link looks a bit odd as we have used quotes and lower case in the various subheadings. The subheadings might be better rewritten but at the same time I don't really want this PR to last for ever :-) |
Looks fine to me, are we ready to merge now? |
I think so. |
Expose upload_rm option in the documentation
Is there a plan to rebase the code for this if we do a 5.0.5 for OMERO? |
I'd leave that at your discretion, @hflynn, though will have to be fairly careful with the likes of |
Ok, probably safer to leave it then. |
--no-rebase |
This is a doc change explaining the
upload_rm
cli import option. It was originally written as a 5.0.4 fix and so made minimal changes to pages. It may be that for 5.1 we will want to further re-organise the import pages.@sbesson This needs the file
/downloads/inplace/advanced-help.txt
pulling in from somewhere. Is there an automatic way to do this?