Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Ice 3.3 and note its removal for 5.1 #763

Merged
merged 10 commits into from May 5, 2014
Merged

Deprecate Ice 3.3 and note its removal for 5.1 #763

merged 10 commits into from May 5, 2014

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2014

  • Backport documentation fixes from 5.1 (use current doc links)
  • Examples are based on Ice 3.5
  • Ice 3.5 will work on Windows from 5.0.2 onward, so remove comments saying otherwise
  • Ice 3.3 support is deprecated in 5.0 and will be removed in 5.1

--rebased-from #760

@hflynn
Copy link
Member

hflynn commented May 1, 2014

We need to clarify if we are claiming Ice 3.5 is supported for Windows for 5.0.2, sounds like @sbesson and @joshmoore might prefer to target 5.0.3, so this PR may need to be left on hold until after the 5.0.2 release. We can discuss the other work that is required when Seb is back.

@ghost
Copy link
Author

ghost commented May 1, 2014

@hflynn Please note that's only a tiny part of this whole PR--like a sentence--and can be reverted if needed. No need to put the whole thing on hold, there's a number of improvements in addition to that.

@hflynn
Copy link
Member

hflynn commented May 1, 2014

Ok, this can be reviewed tomorrow and I'll just make a note that the Windows installation doc may need to be reverted for 5.0.2 if merged.

@ghost
Copy link
Author

ghost commented May 2, 2014

I've removed Ice 3.5 as being supported for Windows in 5.0. This can be addressed separately from the deprecation of Ice 3.3, so this PR is now solely focussed on updating the Ice links and noting Ice 3.3 as being deprecated.

@hflynn
Copy link
Member

hflynn commented May 2, 2014

Thanks @rleigh-dundee, that does make it easier to keep track of things for the release.

@ghost ghost added the dev_5_0 label May 5, 2014
@joshmoore
Copy link
Member

Other than possible link check issues that are ongoing, 👍

@hflynn
Copy link
Member

hflynn commented May 5, 2014

Link is fixed, Jenkins is green again so merging.

hflynn added a commit that referenced this pull request May 5, 2014
Deprecate Ice 3.3 and note its removal for 5.1
@hflynn hflynn merged commit d5814a9 into ome:dev_5_0 May 5, 2014
@hflynn
Copy link
Member

hflynn commented May 6, 2014

N.B. When we confirm Ice 3.5 support for Windows, as well as the commit above being reverted, https://www.openmicroscopy.org/site/support/omero5/sysadmins/limitations.html#ice-3-5 will need deleting too.

@rleigh-codelibre rleigh-codelibre deleted the ice34-minver-dev50 branch June 15, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants