Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making API doc links point at release version #765

Merged
merged 1 commit into from
May 2, 2014

Conversation

hflynn
Copy link
Contributor

@hflynn hflynn commented May 1, 2014

API doc links currently point at the CI builds in Jenkins. This PR makes them point at the release version as linked from the downloads page.

To test, the links are on the front/index page of the staging docs -https://www.openmicroscopy.org/site/support/omero5-staging/

Cc @jburel @sbesson

@sbesson
Copy link
Member

sbesson commented May 2, 2014

Very nice.

@jburel
Copy link
Member

jburel commented May 2, 2014

OmeroJava points to ice33 page. This is about to be deprecated see gh-763.
Link should point to ice34 page.

@hflynn
Copy link
Contributor Author

hflynn commented May 2, 2014

Where the links point is controlled by what is linked from the downloads page @jburel so needs to be changed on the ome-release repo not this PR.

@hflynn
Copy link
Contributor Author

hflynn commented May 2, 2014

@jburel where did you find the link to ice33 docs? All 3 are coming up as 34 for me from the links on the staging index page.

@sbesson
Copy link
Member

sbesson commented May 2, 2014

All subsequent Javadoc links are correctly redirected. See for instance http://www.openmicroscopy.org/site/support/omero5-staging/developers/Modules/Api.html and the console output of http://ci.openmicroscopy.org/view/Docs/job/OMERO-5.0-merge-docs/657/console.
Looks good to merge to me.

@hflynn
Copy link
Contributor Author

hflynn commented May 2, 2014

Thanks Seb, merging and rebasing.

@hflynn
Copy link
Contributor Author

hflynn commented May 2, 2014

--rebased-to #769

@hflynn
Copy link
Contributor Author

hflynn commented May 2, 2014

N.B. we are going to need latest/omero5.1/ redirects if we release concurrently again anyway.

hflynn pushed a commit that referenced this pull request May 2, 2014
Making API doc links point at release version
@hflynn hflynn merged commit cc74050 into ome:dev_5_0 May 2, 2014
@hflynn hflynn deleted the release-api-links branch May 29, 2014 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants