reverseIntensity keyError export #229
Conversation
| @@ -759,7 +759,7 @@ def apply_rdefs(self, image, channels): | |||
| c_idxs.append(i+1) | |||
| windows.append([c['window']['start'], c['window']['end']]) | |||
| colors.append(c['color']) | |||
| reverses.append(c['reverseIntensity']) | |||
| reverses.append(c.get('reverseIntensity', False)) | |||
There was a problem hiding this comment.
Generally 👍 for generalizing the use of get(value, default) for an optional attribute.
Beyond the scope of this fix, as we might be introducing more non-breaking functionalities like reverseIntensity, we might have to think on how best to codify this knowledge using some formal schema/specification so that others can consume the OMERO.figure format/API and know what to expect.
There was a problem hiding this comment.
we will also need old testing data in our setup.
I have created https://trello.com/c/h9WOaIkv/10-produce-older-figures-in-the-testing-db
unless we run nightshade clone somewhere later on on
|
Tested both via editing the json as well as finiding some old figures on eel and verifying that both the edited json as well as the old figure (pre-5.3.0) exports fine. The crash is repeatable on nightshade as well with old figures. All works as expected. Ready to merge. |
Fixes bug with export of images that were added to figures before 'reverseIntensity' was supported (before 5.3.0).
Reported to @kennethgillen from nightshade:
https://trello.com/c/baovPrAJ/7-reverseintensity-keyerror-in-export
To test:
, "reverseIntensity": true(only need to do this for a single active channel of a single image.cc @jburel - We should probably release this as a 3.1.1 bug-fix ASAP.