New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list files user middlename #247

Merged
merged 1 commit into from Dec 20, 2017

Conversation

Projects
None yet
4 participants
@will-moore
Member

will-moore commented Oct 19, 2017

Fixes a minor bug where if a user has a middle-name set, they won't see any files listed when they first open the Files > Open dialog in figure.
Noticed for user-4 in web-dev-merge.

To test:

  • Set a middle-name in user settings (or use user-4 in web-dev-merge) and in figure, Open Files dialog should show your own files when first opened.
@pwalczysko

This comment has been minimized.

Member

pwalczysko commented Oct 20, 2017

works as expected. Ready to merge FMPOV

@joshmoore

This comment has been minimized.

Member

joshmoore commented Oct 24, 2017

This seemed a bit brittle, but I convinced myself that this matches https://github.com/will-moore/figure/blob/56847e09fa0430804288336b256f51445655351a/omero_figure/views.py#L414 so at the moment (other than comments to keep the 2 in sync) this looks good. (There is the potential for an odd name with spaces to cause some confusion. I'm sure @pwalczysko could craft something sufficiently evil. 😄)

@snoopycrimecop snoopycrimecop referenced this pull request Nov 24, 2017

Merged

Rename figure #251

@snoopycrimecop snoopycrimecop referenced this pull request Dec 12, 2017

Merged

Flake8 fixes #256

@jburel

This comment has been minimized.

Member

jburel commented Dec 15, 2017

removed exclude comment

@jburel

This comment has been minimized.

Member

jburel commented Dec 20, 2017

See https://trello.com/c/8rP5sRkv/28-workflow-ii-paper-publication-public-user-on-production-server
@pwalczysko indicated that this was an obvious problem while working on the publication workflow

@jburel jburel merged commit fc94646 into ome:master Dec 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jburel jburel added this to the 3.2.0 milestone Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment