Rename figure

[will-moore]

See https://trello.com/c/dfdmk6Pk/81-rename-figure

To test:

• For a previously saved figure, click on the name to edit it.
• Should be shown an input field to update name
• When focus is lost from input (click elsewhere) or you hit Enter, the name should be updated in the browser (page title (window/tab-name) changes) and input field is replaced again by new name
• This enables the Save button (if not previously enabled) and is added to the Undo/Redo queue.
• When figure is saved and page refreshed, new name should be preserved and File > Open should show new figure name in list.
• Test that unicode names and HTML characters <script>, double quotes etc are handled without errors.
• For new unsaved files, can click where the name should be and insert new name. When you save this will be the default option for saved name.

[bramalingam]

Tried all the workflows and everything works as expected.

Not sure if this is a bug but,

1. Try renaming a file , save button gets enabled. After I save the file, I did cmd+z (undo), and the name of the file went back to the old file name. But the save button did not get enabled. I would have expected it to be enabled, if the undo operation was switching the name back to the old file name.

[will-moore]

@bramalingam This seems to be working for me now... Can you show me?

[bramalingam]

Hmmmm, seems to be working now! And in safari as well, not sure how it did not work on Friday.

[will-moore]

Yeah, I seem to remember when you first reported it that it wasn't working for me, but seems fine now both locally and on web-dev-merge.

[will-moore]

If this is good to merge, then it would be great to merge it since the Travis fix is needed to get all other PRs passing. @jburel

[jburel]

instead of capping flake8
you should declare the expected exception in the script
That's what I had to do in this PR
ome/omero-scripts#136

[jburel]

link might be ok :-)

[snoopycrimecop]

Conflicting PR. Removed from build FIGURE-merge#587. See the console output for more details.
Possible conflicts:

• PR remove_create_original_file_from_file_obj #239 will-moore 'remove_create_original_file_from_file_obj'
  • omero_figure/views.py
• PR Big images #243 will-moore 'Big images'
  • omero_figure/views.py
• PR list files user middlename #247 will-moore 'list files user middlename'
  • omero_figure/views.py

--conflicts Conflict resolved in build FIGURE-merge#624. See the console output for more details.

[jburel]

Discussed today with @will-moore, he will extract the flake8 related commits out of this PR

[will-moore]

Cherry-picked flake8 commits from above to #256.
I think I'll close this until that is merged, since it may otherwise cause merge conflicts.

[will-moore]

@jburel I just found this PR which was tested but not merged before. Good to include this in next release.

[jburel]

Let's do a final review with the next build

[will-moore]

Added this to Help PR: ome/ome-help#284

[jburel]

When figure is saved and page refreshed, new name should be preserved and File > Open should show new figure name in list.

The list was not refreshed after saving.
I was expecting the list to be updated without having to click the refresh button

[jburel]

Entering ```<<<testfor example for the name does not work. When I press enter only<<`` is kept

[will-moore]

@jburel Pushed 2 fixes.

[jburel]

Works nicely now
Thanks.