-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.3 qp workflow #6
Conversation
Ready for review cc @melvingelbard |
Looks good to me! I was a bit confused at the bit where it refers to It's very nice to see tutorials on this. Looking forward to working more on the extension and listening to more feedback for improvement! |
docs/qupath.rst
Outdated
|
||
Save detection ROIs using ome-omero-roitool | ||
------------------------------------------- | ||
This workflow necessritates the usage of the Command Line Interface. The limitation here are the Annotation ROIs, whcih are transformed into masks in OMERO. Although this preserves the holes in the Annotations, if the Annotation ROIs are too large, it might result in performance problems or even running out of resources on the machine where the export of the mask from QuPath is attempted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo "necessritates"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and "whcih"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 00853dd
Looks good (at https://omero-guides--6.org.readthedocs.build/projects/qupath/en/6/qupath.html 👍 ). |
fixes pushed e7fc3cc, 7e49f72 cc @melvingelbard - Re the In OMERO, all ROIs are a subtype of annotaion, other annotations might be e.g. key-value pairs, or Tags etc. |
@will-moore fix pushed 00853dd |
Looks great, thanks. |
@will-moore thank you. @jburel can we merge please so that we are ready for next week's outreach ? |
@pwalczysko I have adjusted the permissions on that repo, so that next time you can merge |
@jburel thank you |
In preparation of the Turku workshop, adding new features to the guide.
Ready for review.
cc @jburel