Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiling threshold max projection bytes #349

Merged
merged 4 commits into from
Feb 16, 2021

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Aug 28, 2020

Fixes #341.

This boosts the "Big Image" (use tiles) threshold in iviewer from 2k * 2k to 2048 * 2048.
Also, it makes iviewer respect the value of the server config: omero config set omero.pixeldata.max_projection_bytes.
So, if you boost this value on the server, iviewer will use that value, instead of needing to also update the corresponding config of omero.web.iviewer.max_projection_bytes in iviewer.

To test, an image should be enabled for projection in iviewer IF...

With default settings:

  • The image must be below 1024 * 1024 * 256 bytes (e.g. 1 channel 8-bit image of X, Y, Z: 2048 * 2048 * 64) AND...
  • Image X * Y must be below 2048 * 2048.

If omero.pixeldata.max_projection_bytes setting is doubled to 1073741824 (1024 * 1024 * 512 * 2):

  • The image bytes must be below this limit (e.g. 2 channel 8-bit image of X, Y, Z: 2048 * 2048 * 64) AND...
  • Image X * Y must be below 2048 * 2048.

If omero.web.iviewer.max_projection_bytes setting is set to LESS than omero.pixeldata.max_projection_bytes then this lower threshold will be used:

  • The image bytes must be below this limit (e.g. 2 channel 8-bit image of X, Y, Z: 2048 * 2048 * 64) AND...
  • Image X * Y must be below 2048 * 2048.

@jburel
Copy link
Member

jburel commented Sep 1, 2020

https://merge-ci.openmicroscopy.org/web/webclient/img_detail/138051/?dataset=24051 (user3) has a dimension of 2048 x 2044
and 31 z-sections. The projection is not enabled

@will-moore
Copy link
Member Author

The default max_projection_bytes on the server and iviewer is 1024 * 1024 * 256.
So if you have a 2048 x 2048 x 31 image then you are only allowed 2 bytes per pixel.
e.g. a 2-channel 8-bit image.
That image above has 4 channels of uint16 so it is quite a bit over that threshold.

We need to test setting of a higher values for omero.pixeldata.max_projection_bytes on the merge-ci server.

@jburel
Copy link
Member

jburel commented Sep 1, 2020

That does not match an image of 2048 x 2048 should be enabled for Max-intensity projection

@will-moore
Copy link
Member Author

OK, sorry - I forgot to say that it still has to be below the max_projection_bytes threshold, which is quite a low cut-off for images that are 2048 x 2048, as discussed at #341 (comment)

So, if we leave the omero.pixeldata.max_projection_bytes at the default setting then we need an image of just the right size to test that smaller 2048 x 2048 images can be projected.
But we also need to test that different settings are respected by iviewer (and the server) to allow bigger images to be projected.

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/z-projection-disabled-big-images/26125/7

@jburel
Copy link
Member

jburel commented Feb 16, 2021

retested, it works as expected
Thanks

@jburel jburel merged commit d8f77da into ome:master Feb 16, 2021
@sbesson
Copy link
Member

sbesson commented Mar 26, 2021

See IDR/deployment#322 (comment) for a compatibility issue with OMERO.server 5.6.0

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/z-projection-disabled-in-viewers-for-big-images/54181/2

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/maximum-intensity-projection-feature-in-omero-web/54392/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projections and tiled images threshold
4 participants