-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ?show=screen-123 for mapr jstree #45
Conversation
I need to investigate |
@joshmoore You were going to review this today, but I'm going to try a different approach using |
ok.
`KeyError: 'active_user'` if not logged in
Otherwise, looks 🆗. I'd want us to also test this in the context of an IDR test server just to be sure though. |
Hmmm, not sure what's causing that but e.g. http://idr.openmicroscopy.org/mapr/api/gene/paths_to_object/?map.value=INCENP&screen=1101 seems to work OK. |
Is this ready for relisting ? |
@sbesson Yes. The test link is in the description. http://web-dev-merge.openmicroscopy.org/mapr/gene/?value=CDK5RAP2&show=project-4501 (user-3) |
Tested using the workflow described above. In general selecting the mapr value and the container ID works as expected selecting the correct element on the tree.
Overall, no objection to merging and tagging as |
Tested as part of today's review of the gallery app on IDR. Merging for a pre-release |
This adds support for the URL e.g.
?show=screen-2
so that we can link to a Study within a Gene etc.This may be a useful entry point if we use a different UI / App to do the initial mapr query, then we want to link to a particular study within a matching term in the mapr app.
E.g. http://web-dev-merge.openmicroscopy.org/mapr/gene/?value=CDK5RAP2&show=project-4501 (user-3)
In mapr, this will load Genes that match value
CDK5RAP2
. With the 'show' query, we load the top level gene nodes of the tree, to check their "study" children for a match with the 'show' query. If we find a match then this node is selected and expanded.NB: This is a different approach from the
webclient/?show=image-2
where the node may be deep in the tree and needs us to load the "path" to this node before expanding all the nodes along the path. Here, we know that the "study" will be one level below the "Genes" that are children of the root node. So we can simply expand each and look for the "study". This will expand some nodes unnecessarily, but the number will be small since most e.g. Genes don't have many homologues (not many children of the root node).To test:
/mapr/gene/?value=CDC5&show=screen-51