Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move path.py to omero_ext #123

Merged
merged 3 commits into from
Nov 26, 2019
Merged

Move path.py to omero_ext #123

merged 3 commits into from
Nov 26, 2019

Conversation

joshmoore
Copy link
Member

fix #117

@sbesson
Copy link
Member

sbesson commented Nov 19, 2019

Immediate thought is that the impact of this change might be fairly large since only in OME, multiple downstream Python components depend on this import.

On the other hand, having the path.py module under the root namespace is certainly a bug which is now becoming critical as we are promoting the installation of this library in a classical Python virtual environment.

My vote goes toward investing into the namespacing effort. Other potential candidates to review might be runProcessor.py runTables.py shellserver.py although some of them might be candidates for migrating under bin/

@joshmoore
Copy link
Member Author

joshmoore commented Nov 19, 2019

Re-included though ome/omero-scripts#160 will need fixing before we merge (otherwise script PRs will start failing)

joshmoore added a commit to joshmoore/omero-scripts that referenced this pull request Nov 19, 2019
joshmoore added a commit to joshmoore/openmicroscopy that referenced this pull request Nov 19, 2019
joshmoore added a commit to joshmoore/ome-documentation that referenced this pull request Nov 19, 2019
joshmoore added a commit to joshmoore/ome-documentation that referenced this pull request Nov 19, 2019
joshmoore added a commit to joshmoore/omero-scripts that referenced this pull request Nov 19, 2019
joshmoore added a commit to joshmoore/openmicroscopy that referenced this pull request Nov 19, 2019
joshmoore added a commit to joshmoore/omero-dropbox that referenced this pull request Nov 19, 2019
joshmoore added a commit to joshmoore/omero-web that referenced this pull request Nov 19, 2019
joshmoore added a commit to joshmoore/omero-dropbox that referenced this pull request Nov 19, 2019
@joshmoore
Copy link
Member Author

I think all PRs are now open that would allow this PR to be un-excluded, but waiting on ome/omero-scripts#160 to go green.

cc: @will-moore @sbesson

@sbesson
Copy link
Member

sbesson commented Nov 21, 2019

From my side with 5.6.0-m2 behind us, no objection to seeing this unexcluded.

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Nov 21, 2019

Conflicting PR. Removed from build OMERO-python-superbuild-push#79. See the console output for more details.
Possible conflicts:

--conflicts Conflict resolved in build OMERO-python-superbuild-push#80. See the console output for more details.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, I am in favor of getting this PR merged together with all companion PRs which are implementing a backwards compatible way to deal with the import renaming. This is effectively a breaking change which will need to be documented appropriately in the changelog of this repository. However, due to the interference with upstream path in conda environment, this is largely unavoidable.

Moving forward we will want to review whether switching to the upstream path module is a possibility when time allows.

@sbesson
Copy link
Member

sbesson commented Nov 26, 2019

Merging and tagging as 5.6.dev6

@sbesson sbesson merged commit 5b7dd96 into ome:master Nov 26, 2019
@joshmoore joshmoore deleted the omero_ext.path branch December 2, 2019 20:40
@joshmoore joshmoore added this to the 5.6.0 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'path' from 'path'
3 participants