Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test in travis #136

Merged
merged 32 commits into from
Dec 4, 2017
Merged

Test in travis #136

merged 32 commits into from
Dec 4, 2017

Conversation

jburel
Copy link
Member

@jburel jburel commented Oct 18, 2017

With this PR, all scripts are tested in travis instead of OMERO.
This should prevent the failure we have in main CI (movie test is off) or devspace CI (driver for that investigation)

The file script.py has been copied from OMERO but this should be available from testlib
A PR will be required in OMERO in order to change that.

The test for make_movie is marked as broken due to a codec issue.
see https://trello.com/c/AlN5hp6g/144-make-movie-tests-failures

Using another encoder will be a good idea but it is not a top priority at the moment.
I am not planning to do so in this PR.

cc @sbesson @joshmoore

Such strategy could be used too in https://github.com/openmicroscopy/omero-example-scripts

@joshmoore joshmoore changed the base branch from develop to clisplit November 21, 2017 15:08
@joshmoore
Copy link
Member

Locally passing with:

==================== 26 passed, 1 xfailed in 248.56 seconds ====================

Let's see what travis says!

@joshmoore
Copy link
Member

Kaching

@joshmoore joshmoore changed the base branch from clisplit to next_infra November 30, 2017 16:35
@joshmoore
Copy link
Member

Merging. As per https://trello.com/c/65fh1AUq/48-remove-pytest-command-and-clipy, I'm going to delay trying to remove cli.py and PytestCommand until we're closer to the 5.4.2 release.

@joshmoore joshmoore merged commit 0214540 into ome:next_infra Dec 4, 2017
@jburel
Copy link
Member Author

jburel commented Dec 12, 2017

@joshmoore 2dff8d7 and 3674b20 will need to be extracted since we now have the same problem on the newly created worfklows branch and on #137

@joshmoore joshmoore added this to the 5.4.2 milestone Jan 18, 2018
@jburel jburel deleted the test-in-travis branch August 21, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants