Web apps

[jburel]

Changes require to use test-infra for figure and iviewer
We will need to go a step further if we want to handle repo like https://github.com/MicronOxford/webtagging
(2 apps in one repo)

Check that
ome/omero-iviewer#155 is green
ome/omero-figure#259 is green

I will work on the README when we are happy with the change.

[joshmoore]

This makes me wonder if we don't want linting in a script. And that makes me wonder if we don't want a default file (including release and version-bump) in this repo and it gets used IFF .omeroci doesn't provide one.

[jburel]

removing from check from py-setup will be necessary since I am now having to combine 2 "dockers" => flake8 is run twice

[joshmoore]

(2 apps in one repo)

I would hope that it could be solved by cloning twice.

[joshmoore]

Along with the two NAME comments, perhaps time to push the changes to the *-docker scripts. I can do that if you'd like.

[joshmoore]

This line itself does nothing (other than throw an exception if the variable is not set) With the introduction of utils, can we push the NAME creation there?

[jburel]

Now that I managed to get things to work with the recent changes I will do a review of the various sections and readme.

[joshmoore]

If NAME detection is done in utils, then this method can be removed in favor of run app config

[jburel]

Planning to do a full review
Do we also get rid of the printf?

[joshmoore]

From the individual $type-$type scripts? I would. That way it can all be controlled by run().

[joshmoore]

Nice. I have some changes on top (docker cli needs some work) but I would wait until this is merged so we're all working from the same point.

[jburel]

3c20072 is required for ome/scripts to work

[jburel]

@joshmoore last 3 commits required to remove the variables as discussed and to fix ome/scripts. Everything is green now
I have not touched cli and lib since you will do some adjustments in a follow-up PR

[joshmoore]

Did you intend to remove this?

[jburel]

yes
let me remove the comment.
I had to move it to another file, since i now use --user to run the tests (failures in ome/scripts otherwise)

[jburel]

@joshmoore removed

[joshmoore]

Thanks. LGTM. I'd say let's get this in. Happy for it to be 0.2.0 and then my follow-ups can either be 0.2.1 or 0.3.0 as needed.

[joshmoore]

Discussed with J-m:

• I'm merging & tagging
• He's updating figure & iviewer to point to origin/master
• Next we'll look into activating cron jobs on the other repos