-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web apps #3
Merged
Merged
Web apps #3
Changes from 9 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
7989674
Add dependencies set-up
jburel 9a0f628
Change order
jburel 247642c
Run command as root
jburel a556a4c
Rename file
jburel 712295f
Add option to exclude files
jburel a27ce10
Add new parameter
jburel 8dae16c
Simplify exclude check
jburel 70bfa7a
Specify parameter to run test command
jburel 1ed0bbc
Run test as root
jburel ac139d9
Add dependencies
jburel 0b54888
Specify directory
jburel aa80f7d
Rename file used to override
jburel fd20c52
Split setup
jburel 4e76c70
Add steps
jburel db79034
Minor fix
jburel bdba0de
Review files
jburel 8f5d216
Remove line added while debugging
jburel 044b49f
Copy before start up
jburel e143dec
Fix permissions
jburel 6a5b2bd
Fix parameter passing
jburel 1811aa9
Run the test setup before running test
jburel 1a8a534
Configure the app by default using name
jburel be4b74d
Merge remote-tracking branch 'origin/master' into web-apps
jburel e24eadd
Introduce app-config file
jburel c91a334
Add option so both app and scripts can be used at the same time
jburel 61380a6
Use script dependencies
jburel e3a757a
docker: add wrapper for all stages
joshmoore ba4329a
docker: fix for "lib" stage and other issues
joshmoore 429bc49
docker: add --user support
joshmoore 2160444
Fix typo and ignore deps
jburel 18fbe90
invoke correct file
jburel 636e4bb
Ignore app-build
jburel d3ca50d
Look for setup.py
jburel 777ad40
Remove newly introduced variables
jburel 07c5581
No longer use DIR as a parameter
jburel adb1d9f
include utils file
jburel 8ab5ca5
Fix name
jburel 5657034
Fix path
jburel be85c38
Add setuptools
jburel d9b1c4b
Move method to utils and fix configuration
jburel 31433dd
Update readme
jburel 5d05727
Use bash
jburel a01beeb
Remove printf
jburel fdbd628
Use new approach
jburel 3c20072
Do not run test as root
jburel 81e8c41
Export variables
jburel b937610
Add extra step
jburel 82819c1
Remove export
jburel 108ad83
Remove commented out code
jburel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me wonder if we don't want linting in a script. And that makes me wonder if we don't want a default file (including
release
andversion-bump
) in this repo and it gets used IFF.omeroci
doesn't provide one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing from check from
py-setup
will be necessary since I am now having to combine 2 "dockers" => flake8 is run twice