disk usage percent fix

[will-moore]

See https://forum.image.sc/t/omero-web-reports-disk-usage-incorrectly/42219

This rounds the usagePercent value before casting it to Int, to avoid strange JavaScript parseInt behaviour of ignoring exponentials for very small numbers (see example in link above).

To test: - probably not so easy to create multi-petabyte free disk space.
So might have to just check the code change against the examples in the link above.

[imagesc-bot]

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omero-web-reports-disk-usage-incorrectly/42219/2

[pwalczysko]

On merge-ci, this seems to be okay (?) Although how many TB do we have for our peruse there ?
https://merge-ci.openmicroscopy.org/web/webadmin/stats/
Even 1 TB seems excessive to the best of my knowledge, so not sure here.
The ratio counted seems correct, it is 3%

Edit: thinking about it a bit more, unless I count in some docker magic, it is sheerly not porrible that there are more than one TB of data on merge-ci ? cc @joshmoore

@sbesson explained that the number is plausible, see screenshot below (only the usage of the idr user) - the usage number is pushed up as this server is used for idr datasets testing

[joshmoore]

bash-4.2$ pwd
/uod/idr-scratch/merge-ci/omero-server-data
bash-4.2$ du -sh *
4.8G	BioFormatsCache
1.0K	DropBox
2.3G	Files
3.5G	FullText
66G	ManagedRepository
51G	Pixels
53M	Thumbnails

[pwalczysko]

Thanks @joshmoore - the numbers in #211 (comment) seem to match more what I would expect from the top of my head.

Is the discrepancy between the web report (supported by @sbesson ) and the numbers in #211 (comment) caused by in-place imports ? And if yes, then actually, what is it that web reports there ? What is the "disk usage" of in-place imported data ? Possibly web does not take the in-place quality of the files into account ?

[joshmoore]

Confirmed separately. Free size comes from df. Used size comes from a query in the database (which ignores symlinks).

[will-moore]

The web UI reports diskFree / (diskFree + usedSize) as a percentage.
If anyone wants to propose an update to the UI that tries to take into account the in-place imported data, please go ahead and open a new issue.
But I think the bug-fix here to the current functionality is working and can be merged?

[joshmoore]

Certainly no objections for this PR: taking in-place into account is going to require server-side changes. 👍

[sbesson]

As a minor doc RFE, is there some place in the client UI where the caveat about the in-place imports could be mentioned?

[pwalczysko]

Agree with @sbesson about the explanation/warning in the UI.

Could an additional line under "Drive space usage" saying The in-place imported data are not counted correctly. The disk usage might be smaller than indicated.

do the job ?

[will-moore]

Added warning message: