Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle unavailability of LUTs when rendering #5250

Merged
merged 1 commit into from
Apr 17, 2017

Conversation

mtbc
Copy link
Member

@mtbc mtbc commented Apr 13, 2017

What this PR does

Allows images to be rendered even when LUTs cannot be loaded, as in share contexts.

Testing this PR

Test that a user from wholly different groups as the owner can see in the full viewer images that have been shared with them.

Related reading

#4753
#5249
https://trello.com/c/sMxu4Rwi/

@pwalczysko
Copy link
Member

pwalczysko commented Apr 14, 2017

Stacktrace:

  • on your image (user-4) put a Fire LUT and Save.
  • reverse the intensity of this LUT on the image and Save.
  • create a Share with user-1
  • login as user-1, find the Share
  • select the thumb of the image, click Preview tab
  • observe error (error attached to https://trello.com/c/sMxu4Rwi/73-bug-fix-shares (LUT_reverse_then_Share)

Happens with any Reverse intenstiy image in Shares. The presence of LUT in above workflow is not impotant.

SecurityViolation: exception ::omero::SecurityViolation
{
    serverStackTrace = ome.conditions.SecurityViolation: ome.model.display.ReverseIntensityContext:Id_8462 not contained in share
    at ome.security.sharing.SharingACLVoter.throwLoadViolation(SharingACLVoter.java:86)
    at ome.security.CompositeACLVoter.throwLoadViolation(CompositeACLVoter.java:91)
    at ome.security.ACLEventListener.onPostLoad(ACLEventListener.java:102)
...

@pwalczysko
Copy link
Member

LUTs are being ignored by Shares:

  • viewing a Shared image in Preveiw or Full Viewer as non-owner of the share you cannot apply a LUT (UI will allow this, but it will not show in the Full Viewer/Preveiw, instead the previously saved color (e.g. Red) will be displayed). If you change color to Yellow, this will be shown in Full Viewer. But if you select another LUT, the displayed color goes to "default" (e.g. Red).
  • if you create and Save LUT Rnd settings on your image and then share it, the non-owner of the Share will not see the LUT- colored image in Full Viewer or Preview of the Share, instead, he/she will see the "default" color (e.g. red)

@pwalczysko
Copy link
Member

The LUT and Reverse intensity workflows in Insight are fine.

@pwalczysko
Copy link
Member

The widget "Open With" (next to the Full Viewer button) does not bring any results neither when you select Image Viewer, not OMERO.figure, nor IViewer.
screen shot 2017-04-14 at 11 24 45

@pwalczysko
Copy link
Member

The Shares workflow works fine otherwise (did not get the e-mails about the Share creation and comments, but this might be because of the setup of eel (?)). Stopping testing for now.
@mtbc apparently can fix the #5250 (comment) reverse-intensity in shares crash.

@mtbc
Copy link
Member Author

mtbc commented Apr 14, 2017

reverse-intensity in shares crash

should be fixed by 077210d

@jburel jburel mentioned this pull request Apr 17, 2017
@jburel
Copy link
Member

jburel commented Apr 17, 2017

Few comments:

@pwalczysko
Copy link
Member

pwalczysko commented Apr 17, 2017

Also reverse intensity LUTed image in Shares gives now a fallback on the color. Tested both LUTs and reverse intensities. No crashes. This is a workable solution FMPOV.

@jburel
Copy link
Member

jburel commented Apr 17, 2017

The thumbnails will be out of synch when viewing the image with Lut in a share

@jburel
Copy link
Member

jburel commented Apr 17, 2017

Will indicate in the announcement that Lut not available in share is a known limitation
that could lead to thumbnail/main viewer being out of synch

@jburel jburel merged commit 47d2310 into ome:develop Apr 17, 2017
@mtbc mtbc deleted the fix-luts-in-shares branch April 17, 2017 14:22
@mtbc
Copy link
Member Author

mtbc commented Apr 17, 2017

@jburel jburel added this to the 5.3.1 milestone Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants