-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle unavailability of LUTs when rendering #5250
Conversation
pertains to share contexts
Stacktrace:
Happens with any Reverse intenstiy image in Shares. The presence of LUT in above workflow is not impotant.
|
LUTs are being ignored by Shares:
|
The LUT and Reverse intensity workflows in Insight are fine. |
The Shares workflow works fine otherwise (did not get the e-mails about the Share creation and comments, but this might be because of the setup of eel (?)). Stopping testing for now. |
80d32cc
to
45c15bc
Compare
should be fixed by 077210d |
Few comments:
|
Also reverse intensity LUTed image in Shares gives now a fallback on the color. Tested both LUTs and reverse intensities. No crashes. This is a workable solution FMPOV. |
The thumbnails will be out of synch when viewing the image with Lut in a share |
Will indicate in the announcement that Lut not available in share is a known limitation |
👍 Related comment at https://trello.com/c/SrcTVbw3/135-lut-improvements#comment-58f481c96b7c63921664b45e |
What this PR does
Allows images to be rendered even when LUTs cannot be loaded, as in share contexts.
Testing this PR
Test that a user from wholly different groups as the owner can see in the full viewer images that have been shared with them.
Related reading
#4753
#5249
https://trello.com/c/sMxu4Rwi/