-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frap script create figure #32
Conversation
We should probably keep 2 scripts: frap and frap with figure |
The script I am a bit confused what output is there from the script |
This still works fine, even on outreach, after I have manually installed the scripts there. (note that I have to solve the ansible problem on outreach tomorrow with @manics as inticated in the chat ). The absence of the FRAP graph panel in the new figure suggests though that even on outreach, there is no matplotlib installed. Is it a question of adding the installation to the playbook via pypi @manics ?) |
@pwalczysko UI name fixed in ee94c1d |
RFE:
The difference between the two scripts is not whether or not they create an OMERO.figure, but rather, whether or not they create a new image with the FRAP graph on it (and add it to the figure). |
Other than #32 (comment) confusion, it works as expected here. Note that all should be now uploaded to outreach, no need to upload scripts manually there anymore. The playbook will be adjusted once this (and other PRs) are merged (and also when the Kymograph is sorted out) |
@pwalczysko Apologies, I think the confusion at #32 (comment) was because when I first opened this PR I uploaded the modified "simple_frap.py" script to outreach with figure creation. Then I removed figure creation from that script but did not update on outreach. |
@pwalczysko Updated simple_frap.py on outreach now. |
Works as expected. Ready to merge FMPOV |
Frap script create figure
Frap script create figure
Frap script create figure
This adds OMERO.figure creation to a new simple_frap_with_figure.py script.
Time indexes are currently hard-coded (don't span whole movie) and figure has scalebars and timestamp labels.
I've also updated both simple_frap scripts to use
roi_service.getShapeStatsRestricted()
instead of getting numpy data (as in Basel day-2 walkthrough).Also the matplotlib -> PIL image method is changed simply to allow it to run on a Mac. This creates a temp file which isn't deleted (will be cleaned-up when the temp script folder is cleaned up).
To test, use RCC1-FRAP images at http://web-dev-merge.openmicroscopy.org/webclient/?show=dataset-25602 (user-3). These are my own images, so these can be made public.
The jpeg plots come from the Deltavision's own analysis - can be used to tell which image (of same name) gives a good FRAP curve.
practical > python > server > simple_frap_with_figure