Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated FileMarkup.defaultDisplay to use the linkText option #690

Merged
merged 1 commit into from
Apr 15, 2016

Conversation

seweissman
Copy link
Contributor

I was playing around with the FileMarkup helper, trying to get it to generate a text link, e.g.

$html = $helper->defaultDisplay($file, array('linkText'=> 'Download', 'linkToFile' => true, 'linkToMetadata' => false));

I expected this to generate a link with "Download" as the text. Instead it generated a link with the original file name as the text. Looking at the code, the linkText option was not passed on from defaultDisplay to_linktoFile. I believe this change fixes this problem.

@zerocrates
Copy link
Member

Certainly looks like a bug

@zerocrates zerocrates merged commit bd83c29 into omeka:master Apr 15, 2016
@zerocrates
Copy link
Member

Looks good; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants