Fixed search with boolean arguments. #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel-KM
pushed a commit
to Daniel-KM/Omeka-S-module-AdvancedSearchPlus
that referenced
this pull request
Jan 19, 2021
Daniel-KM
pushed a commit
to Daniel-KM/Omeka-S-module-Search
that referenced
this pull request
Jan 19, 2021
Daniel-KM
pushed a commit
to Daniel-KM/Omeka-S-module-AdvancedSearch
that referenced
this pull request
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do an api query with
?…&is_public=0&…or?…&is_public=1&…, it works fine, but sometime the value is?…&is_public=&…, it doesn't work, because the empty value""is not skipped as a null value, but converted into 0, so private.This issue is already fixed for user is_active, or media, etc., but not for the resources and the site pages.