This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
feat: OMG Network deposits from the admin panel #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 23, 2020 14:32
kalouo
changed the title
kalouo
changed the base branch from
mederic-p/plasma-deposit
to
eth-blockchain
…ork/ewallet into admin-panel-deposits
kalouo
changed the base branch from
eth-blockchain
to
mederic-p/plasma-deposit
…ork/ewallet into admin-panel-deposits
jarindr
approved these changes
Dec 8, 2020
mederic-p
approved these changes
Dec 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number:
Closes #1194
Closes #1221
Overview
This PR wires up the deposit flow for the admin panel – along with a few miscellaneous enhancements.
Changes
Enables deposits from the admin panel
Miscellaneous:
Implementation Details
Deposits:
HotWalletTransferChoser.jsBlockchainActionSelector.tsxcomponent refactored for extendability and reusability.BlockchainActionSelectoris used) into TypeScript.amountparameter on/blockchain_wallet.deposit_to_childchain(with added test)