feat(satisfies): support malformed range input

https://docs.npmjs.com/cli/v6/using-npm/semver#hyphen-ranges-xyz---abc
omichelsen · Jul 7, 2023 · 9e5b7a9 · 9e5b7a9
1 parent 282de66
commit 9e5b7a9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -91,6 +91,9 @@ export const compare = (v1: string, v2: string, operator: CompareOperator) => {
  * ```
  */
 export const satisfies = (version: string, range: string): boolean => {
+  // clean input
+  range = range.replace(/([><=]+)\s+/g, '$1');
+
   // handle multiple comparators
   if (range.includes('||')) {
     return range.split('||').some((r) => satisfies(version, r));

diff --git a/test/satisfies.ts b/test/satisfies.ts
@@ -119,4 +119,16 @@ describe('satisfies versions', () => {
       ['2.4.0', '1.2.3 - 2.3.4', false],
     ]);
   });
+
+  describe('malformed input - https://docs.npmjs.com/cli/v6/using-npm/semver#hyphen-ranges-xyz---abc', () => {
+    runTests([
+      ['1.2.3', '> 1.2.3', false],
+      ['1.2.4', '> 1.2.3', true],
+      ['1.2.3', '> 1.2.3 < 1.2.5', false],
+      ['1.2.4', '> 1.2.3 < 1.2.5', true],
+      ['0.0.0', '> 1.2.3 <=  1.2.5   ||   0.0.0', true],
+      ['1.2.5', '> 1.2.3 <=  1.2.5   ||   0.0.0', true],
+      ['1.3.0', '> 1.2.3 <=  1.2.5   ||   0.0.0', false],
+    ]);
+  });
 });