Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace #27

Closed
scalopus opened this issue Nov 13, 2015 · 5 comments
Closed

Namespace #27

scalopus opened this issue Nov 13, 2015 · 5 comments
Labels
Status: Resolved Type: Discussion

Comments

@scalopus
Copy link

Any purpose about why the library is not using namespace?
@robinclart
Copy link
Contributor

Since we don't have any control over which version of PHP the library is gonna be run against and we had some customer on version older than 5.3 we decided not to use namespaces.

@scalopus
Copy link
Author

Are you not like to have a separate branch for EOL PHP? I think developer would love for have some language features that you be able to make a library look pretty. There are some several things that just coming up in recent years to improve the quality of code. ex. PSR standard.

At least, I think to support a library where the dependencies (such the PHP itself) are all obsoleted would risk to a system and a library itself. When step up the new major version of library, it may be a good time to arrange the code to be more practical.

@robinclart
Copy link
Contributor

I'm a practical guy. Doing two versions isn't practical at the moment. Neither for us, nor for our users. This is Thailand, don't underestimate what is still running out there. I'm not saying we won't do it but instead that right now isn't the time.

We're still adding feature quite often and implementing new features twice isn't something I can dedicate time to. We love backward compatibility and being nice to our users, and we hate sunsets and forcing people to put up with the chore of updating just because: pretty.

Giving two separate documentation, with two different way of installing things is confusing. Confused people will in turn contact our support and I'd prefer not have our support spend too much time on those kind of thing if I can help it. Furthermore if we decide to EOL the old way (simple class) we then force users to upgrade their infrastructure if they want the new features because of a choice I made for them. And I'm sure they have better things to do.

I'm happy to debate this further with you but as far as I'm concerned I'm not gonna implement namespace right now just for the sake of perceived "prettiness".

@scalopus
Copy link
Author

Ahhh..... OK. Thank you for give a detail. 💃 🍻
Have fun Friday.

@robinclart
Copy link
Contributor

You're welcome. If you have anything else you want to ask. We're always happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Resolved Type: Discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robinclart @scalopus @guzzilar