-
Notifications
You must be signed in to change notification settings - Fork 74
Conversation
- AliasOrder may become a burden when we want to order aliases in a specific way, IMO - And we've already violated it in over 200 modules
…k#362) ``` Refactoring opportunities ┃ ┃ [F] ↗ `Enum.into/3` is more efficient than `Enum.map/2 |> Enum.into/2` ┃ apps/local_ledger/lib/local_ledger/cached_balance.ex:59 #(LocalLedger.CachedBalance.add_amounts) ┃ [F] ↗ `Enum.into/3` is more efficient than `Enum.map/2 |> Enum.into/2` ┃ apps/ewallet/lib/ewallet/web/websocket.ex:107 #(EWallet.Web.WebSocket.normalize_headers) ┃ [F] ↗ `Enum.into/3` is more efficient than `Enum.map/2 |> Enum.into/2` ┃ apps/ewallet/lib/ewallet/web/v1/error_handler.ex:427 #(EWallet.Web.V1.ErrorHandler.error_fields) ```
@dsdshcym Thanks for submitting this PR! However, we do like the |
Since it's a small change request I took the courtesy to update it just now so it can proceed 🍾 |
I see what happened. So removing the @dsdshcym if you'd like to tackle those please let us know in a couple of days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I noticed that some aliases were grouped and some were left ungrouped. Could you merge these ones I commented?
Apart from that, looks good to merge!
apps/admin_api/lib/admin_api/v1/controllers/transaction_consumption_controller.ex
Outdated
Show resolved
Hide resolved
Thank you! 🎖🥇🍾 🌟 ❤️ |
Issue/Task Number: fixes #362
Overview
This PR upgrades credo to 0.10.0
Changes
See commits list
Implementation Details
This PR deactivates the newly introduced checker
Credo.Check.Readability.AliasOrder
, which I think it's not that useful.And one of aeternity projects also deactivates it as well: https://github.com/aeternity/elixir-node/blob/5c47e8b/.credo.exs#L77