Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Upgrade Credo to 0.9.3 #362

Closed
sirn opened this issue Jul 24, 2018 · 0 comments · Fixed by #433
Closed

Upgrade Credo to 0.9.3 #362

sirn opened this issue Jul 24, 2018 · 0 comments · Fixed by #433
Labels
flag/good first issue 🚸 Good for newcomers kind/refactor ⚙️ This is only about refactoring, no new feature. p5/wishlist A wishlist, nice-to-have but not a priority

Comments

@sirn
Copy link
Contributor

sirn commented Jul 24, 2018

And fix all the reports (hint: a lot)
@sirn sirn added flag/good first issue 🚸 Good for newcomers kind/refactor ⚙️ This is only about refactoring, no new feature. p5/wishlist A wishlist, nice-to-have but not a priority s1/todo and removed s1/todo labels Jul 24, 2018
dsdshcym added a commit to dsdshcym/ewallet that referenced this issue Aug 21, 2018
@dsdshcym
Upgrade credo to 0.9.3 (omgnetwork#362)
4b679b4
dsdshcym added a commit to dsdshcym/ewallet that referenced this issue Aug 21, 2018
@dsdshcym
Deactivate Credo.Check.Readability.AliasOrder checker (omgnetwork#362)
e5270d4 
- AliasOrder may become a burden when we want to order aliases in a
  specific way, IMO
- And we've already violated it in over 200 modules
dsdshcym added a commit to dsdshcym/ewallet that referenced this issue Aug 21, 2018
@dsdshcym
Upgrade credo to 0.10.0 (omgnetwork#362)
c6b74cb
dsdshcym added a commit to dsdshcym/ewallet that referenced this issue Aug 21, 2018
@dsdshcym
Fix credo warning about preferring Enum.into/3 over into/2 (omgnetwor…
5a41887 
…k#362)
dsdshcym added a commit to dsdshcym/ewallet that referenced this issue Aug 21, 2018
@dsdshcym
Fix credo warning about preferring Enum.into/3 over into/2 (omgnetwor…
76a3dad 
…k#362)

```
  Refactoring opportunities
┃
┃ [F] ↗ `Enum.into/3` is more efficient than `Enum.map/2 |> Enum.into/2`
┃       apps/local_ledger/lib/local_ledger/cached_balance.ex:59 #(LocalLedger.CachedBalance.add_amounts)
┃ [F] ↗ `Enum.into/3` is more efficient than `Enum.map/2 |> Enum.into/2`
┃       apps/ewallet/lib/ewallet/web/websocket.ex:107 #(EWallet.Web.WebSocket.normalize_headers)
┃ [F] ↗ `Enum.into/3` is more efficient than `Enum.map/2 |> Enum.into/2`
┃       apps/ewallet/lib/ewallet/web/v1/error_handler.ex:427 #(EWallet.Web.V1.ErrorHandler.error_fields)
```
@dsdshcym dsdshcym mentioned this issue Aug 21, 2018
Merged
dsdshcym added a commit to dsdshcym/ewallet that referenced this issue Aug 30, 2018
@dsdshcym
Sort alias groups in alphabetical order (omgnetwork#362)
e384514
dsdshcym added a commit to dsdshcym/ewallet that referenced this issue Aug 31, 2018
@dsdshcym
Sort alias groups in alphabetical order again (omgnetwork#362)
0bbce54
dsdshcym added a commit to dsdshcym/ewallet that referenced this issue Aug 31, 2018
@dsdshcym
Group aliases with the same prefix (omgnetwork#362)
9e8379b 
- See also
  omgnetwork#433 (review)
unnawut pushed a commit that referenced this issue Sep 3, 2018
@dsdshcym @unnawut
Upgrade credo to 0.10.0 (#433)
fe6d1dc 
* Upgrade credo to 0.9.3 (#362)

* Deactivate Credo.Check.Readability.AliasOrder checker (#362)

* Upgrade credo to 0.10.0 (#362)

* Fix credo warning about preferring Enum.into/3 over into/2 (#362)

* Revert Credo.Check.Readability.AliasOrder back

* Sort alias groups in alphabetical order (#362)

* Sort alias groups in alphabetical order again (#362)

* Group aliases with the same prefix (#362)
@ghost ghost removed the s3/review label Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flag/good first issue 🚸 Good for newcomers kind/refactor ⚙️ This is only about refactoring, no new feature. p5/wishlist A wishlist, nice-to-have but not a priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade credo to 0.10.0 dsdshcym/ewallet
2 participants
@sirn @unnawut