-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mail.ru oauth2 #296
Conversation
Looks good, thanks! |
I spoke too soon. It looks like these commits broke the build: http://travis-ci.org/intridea/omniauth/builds/6922 Damn you merge button!!! @lexer Did you try running |
Sorry, I haven't. =\ Test is broken because of my provider has additional parameter "private_key" that is passed as third parameter. This is not "client secret" and used to create signature to access user info. According to your API I should put mailru privatekey as hash inside options? Am I correct? |
Yes, that is correct. Looking forward to a fix shortly. :) |
Any updates on this? The build has been broken for many hours now. If I don't receive a patch soon, I'll have to revert the merge. |
i've fixed the problem, but i cannot run specs since i fixed it on my friend's laptop with no ruby installed. I can pull this commit: lexer@266bf18, but you'd better to run specs by yourself before merging it. |
Mail.ru is one of largest mail provider and social network in Russia.