Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mail.ru oauth2 #296

Merged
merged 17 commits into from
Apr 29, 2011
Merged

Add support for mail.ru oauth2 #296

merged 17 commits into from
Apr 29, 2011

Conversation

lexer
Copy link
Contributor

@lexer lexer commented Apr 29, 2011

Mail.ru is one of largest mail provider and social network in Russia.

sferik added a commit that referenced this pull request Apr 29, 2011
Add support for mail.ru oauth2
@sferik sferik merged commit cf590f5 into omniauth:master Apr 29, 2011
@sferik
Copy link
Contributor

sferik commented Apr 29, 2011

Looks good, thanks!

@sferik
Copy link
Contributor

sferik commented Apr 29, 2011

I spoke too soon. It looks like these commits broke the build: http://travis-ci.org/intridea/omniauth/builds/6922

Damn you merge button!!!

@lexer Did you try running bundle exec rake spec before submitting this pull request?

@lexer
Copy link
Contributor Author

lexer commented Apr 29, 2011

Sorry, I haven't. =\

Test is broken because of my provider has additional parameter "private_key" that is passed as third parameter. This is not "client secret" and used to create signature to access user info.

According to your API I should put mailru privatekey as hash inside options? Am I correct?

@sferik
Copy link
Contributor

sferik commented Apr 29, 2011

Yes, that is correct. Looking forward to a fix shortly. :)

@sferik
Copy link
Contributor

sferik commented Apr 30, 2011

Any updates on this? The build has been broken for many hours now. If I don't receive a patch soon, I'll have to revert the merge.

@lexer
Copy link
Contributor Author

lexer commented Apr 30, 2011

i've fixed the problem, but i cannot run specs since i fixed it on my friend's laptop with no ruby installed.

I can pull this commit: lexer@266bf18, but you'd better to run specs by yourself before merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants