Sets omniauth.headers on the request phase #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, new to Travis, but it seems all tests are ok but there are some code offenses not introduced by myself. |
|
@waiting-for-dev How's your PR going? Your PR is pretty helpful for many people. |
|
Hey, THIS is the pull request and it has been ready for a long time waiting for some feedback ;) |
sferik
force-pushed
the
master
branch
2 times, most recently
from
a5c7282
to
76feeea
Compare
tmilewski
reviewed
Feb 8, 2017
| it 'sets omniauth.headers on the request phase' do | ||
| OmniAuth.config.mock_auth[:test] = {} | ||
|
|
||
| strategy.call(make_env('/auth/test', 'HTTP_FOO' => 'bar')) |
There was a problem hiding this comment.
Mind testing that it doesn't pick up env's that aren't prepended with 'HTTP_'?
There was a problem hiding this comment.
Well, this PR was just intended to keep header values, which in rack env are always prepended with HTTP_.
|
@waiting-for-dev Would you mind rebasing on Master? |
|
Hey @tmilewski . Rebase done. Please, review it is correct, it has been a long time since I visited it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
env['omniauth.headers']which is a hash with header values on the request phase. Closes #804