Fall back to the discovered jwks when no key specified #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no key has been explicitly specified, key_or_secret may return an
empty value, so when discovery is disabled, JWT decoding fails:
JSON::JWS::VerificationFailed (JSON::JWS::VerificationFailed):
/usr/lib/ruby/vendor_ruby/json/jws.rb:26:in `verify!'
/usr/lib/ruby/vendor_ruby/json/jws.rb:149:in `decode_compact_serialized'
/usr/lib/ruby/vendor_ruby/json/jwt.rb:86:in `decode_compact_serialized'
/usr/lib/ruby/vendor_ruby/json/jose.rb:52:in `decode'
...
The actual discovery is performed in any case, so why not use that key if
nothing else is available.
Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>
andrewshadura
force-pushed
the
use-jwks-when-no-key-specified
branch
from
3bbd6b9
to
a8a0e7a
Compare
nTraum
added a commit
to CitizenLabDotCo/citizenlab
that referenced
this pull request
Jun 9, 2022
…d Bosa FAS (Belgium) This is an attempt to fix the verification error we are seeing in Sentry for Bosa FAS and Clave Unica. Specifically I'm eyeballing the fix introduced in 0.4 here omniauth/omniauth_openid_connect#97. The stack trace matches what we see in Sentry: https://sentry.hq.citizenlab.co/organizations/citizenlab/issues/45980/?referrer=jira_integration https://sentry.hq.citizenlab.co/organizations/citizenlab/issues/46899/?project=2&query=is%3Aunresolved&statsPeriod=14d This is hard to test locally because the documentation at https://www.notion.so/citizenlab/SSO-ID-Verification-263b705ca14e472c8e41b444663e373a#1da11c08825c441687faf4be31fb14f8 is lacking and far as I know we do not have a working sandbox environment for any of the two verification methods. I'd therefore like to blindly deploy it to production and ask Pablo again to verify on a Chilean platform for me.
4 tasks
papayaah
added a commit
to health2works/omniauth_openid_connect
that referenced
this pull request
Oct 7, 2022
…0.4.0 * upstream/master: (32 commits) Fix date in CHANGELOG.md Fixes rubocop issues Setup Coveralls.io as Github Action Fix rubocop errors Replace deprecated rubocop_linter_action Update README.md Fix date on CHANGELOG.md Update VERSION to v0.4.0 Update CHANGELOG.md for v0.4.0 Support dynamic parameters to the authorize URI (omniauth#90) Upgrade Faker and replace Travis with Github Actions (omniauth#102) Try to fix rubocop documentation_url not round error. Make `omniauth_openid_connect` gem compatible with `omniauth v2.0` (omniauth#95) Fall back to the discovered jwks when no key specified (omniauth#97) Allow to update omniauth to 2 (omniauth#88) Update README.md Bump version to 0.3.5 bugfix: info from decoded id_token is not exposed (omniauth#61) bugfix: NoMethodError (undefined method `count' for #<OpenIDConnect::ResponseObject::IdToken:0x0000000008d9dde0>): (omniauth#60) Bump version to 0.3.4 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no key has been explicitly specified,
key_or_secretmay return an empty value, leading to a token decoding error, when discovery is disabled:The actual discovery is performed in any case (but the discovered values aren’t used), so why not use that key if nothing else is available.